Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUT-08: mint fee return any overpaid amount #146

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

NUT-08: mint fee return any overpaid amount #146

wants to merge 3 commits into from

Conversation

thesimplekid
Copy link
Collaborator

@thesimplekid thesimplekid commented Jul 2, 2024 •
edited by callebtc
Loading

Change NUT08 to reflect that should return any over paid amount on a melt even if it is greater then the fee_reserve this avoids wallets having to swap before a melt to get the correct amount.

  • Nutshell
  • CDK
  • Nutmix
  • gonuts
  • ...

@thesimplekid thesimplekid changed the title NUT08: mint fee return NUT-08: mint fee return Jul 2, 2024
@callebtc callebtc changed the title NUT-08: mint fee return NUT-08: mint fee return any overpaid amount Jul 25, 2024
@ngutech21
Copy link
Collaborator

Just one thing to consider: This is changing the existing behavior of a mint. So I think it would be a good idea to signal this change to the wallet by adding a flag to the info-endpoint like supports_overpaying: true or something like that. So the wallet knows exactly how the mint will react.
Otherwise it will be hard for a wallet to figure out what the current behavior of the mint is. The mint is signaling that it supports NUT-08 but not how it will treat an overpayment.

@thesimplekid
Copy link
Collaborator Author

Just one thing to consider: This is changing the existing behavior of a mint.

I don't think is actually changing the behavior of the mint and this is how nutshell implements it already @callebtc could you confirm?

@thesimplekid
Copy link
Collaborator Author

thesimplekid commented Aug 9, 2024 •
edited
Loading

@elnosh @lescuer97 @ngutech21 Can you check and confirm your mint implementations follow this?

gudnuf
gudnuf reviewed Sep 11, 2024
View reviewed changes
05.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gudnuf gudnuf gudnuf left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thesimplekid @ngutech21 @gudnuf